[Enhancement] (Multi Ref Base Table Part2) MVPCTRefreshPlanBuilder supports multi ref base tables in mv refresh (backport #48284) #48444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…pports multi ref base tables in mv refresh (#48284) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit e22a42a)
24 tasks
LiShuMing
previously approved these changes
Jul 16, 2024
Signed-off-by: shuming.li <[email protected]>
|
LiShuMing
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
MVPCTRefreshPlanBuilderis the final step to ensure refresh task to query only the incremental base table's partitions which is very important to reduce mv refresh cost. But it can not generate incremental partition predicates for multi-base ref tables for now, and it may cause whole time scan in mv refresh in some corner cases.What I'm doing:
strict insertin unit tests and SQL tests by default.Fixes #48354
https://github.com/StarRocks/StarRocksTest/issues/8137
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #48284 done by [Mergify](https://mergify.com). ## Why I'm doing:
MVPCTRefreshPlanBuilderis the final step to ensure refresh task to query only the incremental base table's partitions which is very important to reduce mv refresh cost. But it can not generate incremental partition predicates for multi-base ref tables for now, and it may cause whole time scan in mv refresh in some corner cases.What I'm doing:
strict insertin unit tests and SQL tests by default.Fixes #48354
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: